Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(SetTheory/Game/Ordinal): make Ordinal.toGame an order embedding #19417

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore(SetTheory/Game/Ordinal): make Ordinal.toGame an order embedding #19417

wants to merge 2 commits into from

Conversation

vihdzp
Copy link
Collaborator

@vihdzp vihdzp commented Nov 23, 2024

The original reasoning against doing this was that it would disable dot notation, which is no longer an issue in the latest version of Lean.

Open in Gitpod

@vihdzp vihdzp added the t-set-theory Set theory label Nov 23, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 23, 2024 •
edited
Loading

PR summary 8d70aa0009

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ mk_toPGame

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

alreadydone
alreadydone approved these changes Nov 24, 2024
View reviewed changes
Mathlib/SetTheory/Game/Ordinal.lean
Comment on lines -243 to +244
@[simp, norm_cast]
@[simp]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"badly shaped simp lemma, can't start with coe"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alreadydone alreadydone alreadydone approved these changes

Assignees
No one assigned
Labels
t-set-theory Set theory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vihdzp @alreadydone